-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Categorical dashboard filters #1677
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chartConfig.interactiveFiltersConfig.dataFilters.componentIris.some( | ||
(componentIri) => | ||
!dashboardFilters?.dataFilters.componentIris.includes(componentIri) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Could this be part of the chartFiltersState that is computed just below ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
… was incorrect and would still reference the previous value
Closes #1669
This PR introduces categorical dashboard filters.
How to test
To do in the future